异步&多线程-张光宇-无36 #13
Open
异步&多线程-张光宇-无36 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdawej
reviewed
Aug 4, 2024
| public override void Register(Expr parent) | ||
| { | ||
| // TODO 4:注册操作 | ||
| this->parent = parent; |
There was a problem hiding this comment.
this 作为一个引用，显然不应该使用指针的取成员运算符，而是用 this.parent；这里编译无法通过。
asdawej
reviewed
Aug 4, 2024
| public override void Register(Expr parent) | ||
| { | ||
| // TODO 7:注册操作 | ||
| this->parent = parent; |
asdawej
reviewed
Aug 4, 2024
There was a problem hiding this comment.
大体上没什么问题，但是这些计算全部都使用 .Wait() 阻塞住，这并不必要；尝试非阻塞地编写代码，尽可能地利用并行。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
仅完成作业1