-
Notifications
You must be signed in to change notification settings - Fork 63
support core-1.7.0 #1962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
support core-1.7.0 #1962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be2b718 to
5a699e1
Compare
31b1711 to
fd0f910
Compare
Change ndarray tests to use whatever tag is in the current default standard and make other tests either independent of the standard or define a specific one (whichever is more relevant to the test).
9ab1b48 to
8ffe89e
Compare
Contributor
Author
|
I opened this for review but let's wait until asdf-format/asdf-standard#479 is merged and the CI here can be re-run to fix the devdeps. |
zacharyburnett
approved these changes
Sep 19, 2025
Member
zacharyburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approval for when this is ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support new "unstable" schemas (1.7.0) added in asdf-format/asdf-standard#479 by:
ASDF_UNSTABLE_CORE_SCHEMASenvironment variable)ASDF_UNSTABLE_CORE_SCHEMASin devdeps to test unstable version of schemasThe plan is for this PR will stay draft until after the asdf 5.0.0 release and then start testing and eventually update to 1.7.0 as part of a 5.x.x release (I'm not at the moment convinced that a change in default core schema should require a major version bump).
Closes: #1963
Requires asdf-format/asdf-standard#479 first to fix the devdeps (since the referenced Exception does not yet appear in asdf-standard main). Here's a run where the devdeps were run with the linked PR and passed.
Tasks
pre-commiton your machinepyteston your machineno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pagenews fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: bug fixchanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.general.rst: infrastructure or miscellaneous change