test: Add a test for an expr calc using an aggregation in a sort. #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rellen
force-pushed
the
tests/calculation-with-aggregate-expr
branch
from
f99d6fd to
67b9c63
Compare
This replicates an issue seen. We have an expression calculation using a aggregation from a transitive relationship. If that calculation is used in a sort, the text of the expression is passed as the aggregate name, instead of a variable name such as "aggregate0" etc. E.g. ``` * ** (RuntimeError) Unbound aggregate field: "first(comments[field: :created_at, query: [filter: author_id == \"54c6b3da-d3a5-41f6-8409-780fed9fe184\"]])" ```
rellen
force-pushed
the
tests/calculation-with-aggregate-expr
branch
from
67b9c63 to
3343f61
Compare
|
Reproduction for ash-project/ash_sql#173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replicates an issue seen.
We have an expression calculation using a aggregation from a transitive relationship. If that calculation is used in a sort, the text of the expression is passed as the aggregate name, instead of a varaible name such as "aggregate0" etc.
E.g.
Contributor checklist
Leave anything that you believe does not apply unchecked.