fix: determine esbuild binary path at repository instantiation (#234) #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Migrates away from the deprecated @bazel_tools//src/conditions:host_windows condition by determining the correct esbuild binary path at repository instantiation time.
Since each esbuild repository is platform-specific (platform attribute is known when the repository is created), we can directly generate the correct path in the BUILD file without a select statement.
Changes are visible to end-users: no
Test plan
Manually tested that that legacy (< 0.16.0) windows platform naming still works