Remove determine_main rule #641
Open
+76
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
keith
force-pushed
the
ks/remove-determine_main-rule
branch
from
b449adf to
62920f5
Compare
This inlines this into the executable rules instead. Fixes aspect-build#605 Fixes aspect-build#621
keith
force-pushed
the
ks/remove-determine_main-rule
branch
from
62920f5 to
012a826
Compare
keith
commented
Sep 11, 2025
| # NB: we don't use the py_binary macro here, because we want our `main` attribute to be used | ||
| # exactly as specified here, rather than follow rules_python semantics. | ||
| py_binary_rule( | ||
| py_binary( |
There was a problem hiding this comment.
I don't follow what this was testing, but it was trying to force a main file w/o any srcs. if im missing something this case likely doesn't work with this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inlines this into the executable rules instead.
Fixes #605
Fixes #621