Skip to content

Conversation

@willwade
Copy link
Collaborator

@willwade willwade commented Sep 1, 2025

Creates a big modal window. Not sure about this. @ms-mialingvo take a look

attempt at a #583

Creates a big modal window. Not sure about this
@willwade willwade changed the title attempt at a #583 Feature: Custom-Color-Themer Sep 1, 2025
@willwade
Copy link
Collaborator Author

willwade commented Sep 1, 2025

@ms-mialingvo
Copy link
Collaborator

It's working well and looking good for me! Any UI/UX improvements are something to be done separatedly, with #480.

Copy link
Contributor

@klues klues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! 👍
I've reviewed the code and added quite some comments. I hope they're understandable - especially the very long one about data flow 😉

@github-actions
Copy link

🎉 Beta deployment successful! 🎉

You can view the changes in the live preview environment here: https://gridbeta-github.asterics-foundation.org/willwade/feature-custom-colour-themer/pr

…ive scheme stays valid after deletes

Ensure active scheme stays valid after deletes - If a custom scheme gets deleted in the modal and it was the active one, we now fall back to the default scheme before saving.
Replaced constants.createCustomColorScheme(...) with a small local builder that creates categories for the selected base and an all-white palette (and adds Fitzgerald mappings when relevant). This makes the editor robust even if it initializes in “create” mode.
@willwade willwade requested a review from klues September 11, 2025 20:20
@github-actions
Copy link

🎉 Beta deployment successful! 🎉

You can view the changes in the live preview environment here: https://gridbeta-github.asterics-foundation.org/willwade/feature-custom-colour-themer/pr

@MinecraftMoments
Copy link

this is very good visually! i think being able to create custom categories would also be nice (since i don't use purple for places, places are nouns, and i use the "place" category / purple color for questions instead), but other than that, this already works basically exactly as i requested!!

@willwade
Copy link
Collaborator Author

this is very good visually! i think being able to create custom categories would also be nice (since i don't use purple for places, places are nouns, and i use the "place" category / purple color for questions instead), but other than that, this already works basically exactly as i requested!!

Yeah I had done that but its really complicated - we settled so far on duplicating an existing theme and editing that than doing it by scratch due to the various different ways you'd have to categorise button types. Maybe we release it as is and think how we do this for a future Issue

@arasaac-dga
Copy link
Collaborator

Works as expected! Why is "Base Scheme Type" deactivated in the modal window? It’s confusing to see it disabled while knowing that the modal window actually uses the active color scheme. We think it would be better if it were active, so you could change the color scheme directly in the modal window from the one you want to start with.

@github-actions
Copy link

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/willwade/feature-custom-colour-themer/pr

@arasaac-dga
Copy link
Collaborator

The "Save" button in modal window doesn't work :-( You cannot save new custom-color theme.

The "Base Scheme Type" is activated now and you can select whatever regular scheme as base to modify.

@arasaac-dga are fast on their reviews!
@github-actions
Copy link

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/willwade/feature-custom-colour-themer/pr

@arasaac-dga
Copy link
Collaborator

​Now works the "Save" button BUT if you edit a custom-color scheme created and change the name, the system creates a new scheme with this new name not rename the actual one that is the expected behaviour.

@github-actions
Copy link

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/willwade/feature-custom-colour-themer/pr

@willwade
Copy link
Collaborator Author

Think thats working @arasaac-dga - thanks for your help. That was faster than me finding that! I feel something might still be not working but cant figure out what..

@arasaac-dga
Copy link
Collaborator

Now the problem is that when you create a New Theme doesn't save the name. Always is "New theme". But after create it, you can rename it without problem.

@Fukurouonthesea
Copy link

this is very good visually! i think being able to create custom categories would also be nice (since i don't use purple for places, places are nouns, and i use the "place" category / purple color for questions instead), but other than that, this already works basically exactly as i requested!!

Yeah I had done that but its really complicated - we settled so far on duplicating an existing theme and editing that than doing it by scratch due to the various different ways you'd have to categorise button types. Maybe we release it as is and think how we do this for a future Issue

(just reading through things: could you rename existing categories as a mid step? instead of creating new ones. Maybe that'd be easier.
Example - I use (place) purple for all socials, and (social) pink for medical, and so on. It works, but would be nicer to be able to assign them without remembering the "translations".)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants