Skip to content

Conversation

@kargarisaac
Copy link

  • Add dqn for non-frame state spaces
  • Add loading and evaluation code for the trained model

@kargarisaac kargarisaac mentioned this pull request Apr 7, 2020
@kargarisaac
Copy link
Author

Example_9 file contains using dqn for cartpole with a custom model and evaluation function.

@petrikvladimir
Copy link

Thank you! That explains why DQN did not work for my tasks. Your pull request is, however, quite complicated. Wouldn't just changing
self.replay_buffer = ReplayCls(**replay_kwargs) into
self.replay_buffer = ReplayCls(**replay_kwargs) if self.ReplayBufferCls is None else self.ReplayBufferCls(**replay_kwargs) in the DQN algorithm solve that issue?

@kargarisaac
Copy link
Author

@petrikvladimir It does if you set the class as input. I just added the same settings as the atari env for non-atari envs to do it automatically.

@Adithya-MN
Copy link

Adithya-MN commented Nov 1, 2020

@astooke, is there any issue with this merge? This would really be a useful functionality to have officially

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants