Skip to content

Handle unused variables in the project #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Handle unused variables in the project #383

wants to merge 1 commit into from

Conversation

krishnakumarg1984
Copy link
Collaborator

@krishnakumarg1984 krishnakumarg1984 commented Jun 22, 2023 •
edited
Loading

Closes #384.

@krishnakumarg1984 krishnakumarg1984 self-assigned this Jun 22, 2023
@krishnakumarg1984 krishnakumarg1984 mentioned this pull request Jun 22, 2023
Open
@krishnakumarg1984 krishnakumarg1984 force-pushed the kg/handle_unused_variables branch from a4dfb5a to a4c0bda Compare June 22, 2023 21:00
@tkoskela
Copy link
Contributor

I think in general commented out bits of code with no explanation just confuse the reader. If there are unused variables, go ahead and remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcleod89 mmcleod89 Awaiting requested review from mmcleod89

@tkoskela tkoskela Awaiting requested review from tkoskela

@SJaffa SJaffa Awaiting requested review from SJaffa

At least 1 approving review is required to merge this pull request.

Assignees

@krishnakumarg1984 krishnakumarg1984

Labels
code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle unused variables in the project
2 participants
@krishnakumarg1984 @tkoskela