-
-
Notifications
You must be signed in to change notification settings - Fork 69
Add a way to do reprojection without dumping dask arrays to memory maps and switch default for reproject_interp to not write to memory maps #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
==========================================
+ Coverage 90.12% 91.06% +0.94%
==========================================
Files 30 30
Lines 1822 1858 +36
==========================================
+ Hits 1642 1692 +50
+ Misses 180 166 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1c9af09 to
e29a834
Compare
e29a834 to
4f87347
Compare
af19c07 to
1eba27d
Compare
|
This seems to work - the main question now will be whether to rename the 'none' option or change the keyword argument to |
|
@Cadair @svank this adds a dependency on a very recent version of dask-image, which means also bumping the minimum dask version to one that is around a year old. I don't really foresee issues with this since pip/conda should just do their thing when people install reproject, but let me know if you are opposed to adding this dependency. |
|
I'm fine with that, very happy for dask-native reproject! |
Cadair
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't given this a super detailed review but it looks good to me.
| except ValueError as exc: | ||
| # If arrays are too small, spline_filter can fail, so we catch this | ||
| # case and call the scipy version if so | ||
| if "The overlapping depth" in str(exc): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 the horror.
Very much just work in progress, not ready for testing