Skip to content

Conversation

@astrofrog
Copy link
Member

Very much just work in progress, not ready for testing

@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

❌ Patch coverage is 98.07692% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.06%. Comparing base (4f8e9eb) to head (939393b).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
reproject/array_utils.py 97.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
+ Coverage   90.12%   91.06%   +0.94%     
==========================================
  Files          30       30              
  Lines        1822     1858      +36     
==========================================
+ Hits         1642     1692      +50     
+ Misses        180      166      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@astrofrog astrofrog force-pushed the dask-native-reproject branch from e29a834 to 4f87347 Compare November 12, 2025 10:17
@astrofrog astrofrog force-pushed the dask-native-reproject branch from af19c07 to 1eba27d Compare November 12, 2025 14:39
@astrofrog
Copy link
Member Author

This seems to work - the main question now will be whether to rename the 'none' option or change the keyword argument to memmap_dask=True/False for clarity.

@astrofrog astrofrog changed the title WIP: add a way to do reprojection without dumping dask arrays to memory maps Add a way to do reprojection without dumping dask arrays to memory maps and switch default for reproject_interp to not write to memory maps Nov 12, 2025
@astrofrog astrofrog marked this pull request as ready for review November 13, 2025 11:23
@astrofrog
Copy link
Member Author

@Cadair @svank this adds a dependency on a very recent version of dask-image, which means also bumping the minimum dask version to one that is around a year old. I don't really foresee issues with this since pip/conda should just do their thing when people install reproject, but let me know if you are opposed to adding this dependency.

@Cadair
Copy link
Member

Cadair commented Nov 13, 2025

I'm fine with that, very happy for dask-native reproject!

Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't given this a super detailed review but it looks good to me.

except ValueError as exc:
# If arrays are too small, spline_filter can fail, so we catch this
# case and call the scipy version if so
if "The overlapping depth" in str(exc):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 the horror.

@astrofrog astrofrog merged commit e54cd7c into astropy:main Nov 13, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants