Support ArgValue being None to send an empty message #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I think you need a type here |
buckbanzai
force-pushed
the
support-none-argvalue
branch
from
6f3323b to
0a61787
Compare
Contributor
Author
|
Hiya, it's my understanding that using None this way is the preferred way to write a NoneType for Python 3.x: https://peps.python.org/pep-0484/#using-none, but happy to change it to a NoneType if you'd prefer. I believe the previous lint checks and tests the runs failed due to some of the formatting issues that #189 solved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya,
Submitting this PR to add support for
ArgValuebeing set toNone, since it looks like thesend_messagefunctions have support for them, but they aren't listed as a supported type.I can edit this to move it to only apply as a Union on the
send_messagefunctions if you'd prefer.Thank you!