Providing new method to enable patch clients credential endpoint #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for raising the PR!! Request you to sign your commits. |
|
The PR looks good overall! Just a few points:
Post that we are good to merge the PR. Thank you |
…l method - Add test cases for updateCredential method including null parameter validation - Add comprehensive client credential management documentation to EXAMPLES.md - Include examples for all credential CRUD operations with required scopes - Document the new updateCredential functionality with proper usage examples
marcossegovia
force-pushed
the
support-for-patch-clients-credentials
branch
from
204acc2 to
68c9192
Compare
|
Hi @tanya732 it should be all set. Sorry the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces support for updating an existing client credential via the Auth0 Management API.
ClientsEntity.updateCredential(String clientId, String credentialId, Credential credential)A new method that issues a
PATCHrequest to/api/v2/clients/{client_id}/credentials/{credential_id}.expires_atproperty, which is the only one documented today.update:client_credentialsscope.References
Please include relevant links supporting this change such as a:
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist