Skip to content

Refactor PromptRendering handling #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactor PromptRendering handling #594

wants to merge 1 commit into from

Conversation

ramya18101
Copy link
Contributor

🔧 Changes

  • Removed custom MarshalJSON method from PromptRendering, relying on default JSON marshaling.
  • Updated cleanForPatch to always return a fully populated struct for consistency in patch operations.

📚 References

🔬 Testing

  • Strengthened TestPromptManager_ListRendering with assertions for Screen and Prompt field equality.
  • Enhanced givenAPromptRendering helper to re-fetch and validate settings after updates.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ramya18101
Copy link
Contributor Author

Yet to re-record the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ramya18101