Skip to content

Conversation

@fern-api
Copy link
Contributor

@fern-api fern-api bot commented Oct 23, 2025

This pull request introduces several improvements and refactors to the management client codebase, focusing on unifying client option types, updating resource accessors, and enhancing developer tooling. The most significant changes include the extraction and consolidation of base client and request option types, the addition and removal of certain resource clients, and updates to developer scripts and dependencies.

Client and API Refactoring:

  • Extracted common client and request options into BaseClientOptions and BaseRequestOptions in a new BaseClient.ts file, and updated all relevant API and resource client interfaces to extend from these base types for improved consistency and maintainability.

  • Updated the Actions resource client to use the new base option types and improved the list method's example and query parameter handling for better type safety and clarity.

Resource Changes in Management Client:

  • Added the userAttributeProfiles and organizations.discoveryDomains resource accessor and removed the groups resource accessor from the ManagementClient, reflecting changes in available API resources.

API Exports and Error Files:

  • Added a new export for API request types via src/management/api/requests/index.ts and updated the main API index file to include this export.

  • Standardized the comment headers in all error files to a consistent single-line format.

Developer Tooling and Dependency Updates:

  • Added new formatting and linting scripts (format:check, lint, lint:fix, check, check:fix) to package.json for improved code quality workflows.

  • Updated the msw and prettier dependencies to use fixed versions, and added biome.json to .npmignore.

These changes collectively improve code maintainability, developer experience, and ensure the client reflects the current state of the API.

@fern-api fern-api bot requested a review from a team as a code owner October 23, 2025 12:40
@developerkunal developerkunal changed the title 🌿 Fern Regeneration -- October 23, 2025 feat(management-client): add userAttributeProfiles & organizations.discoveryDomains, remove groups, refactor client options Oct 23, 2025
@developerkunal developerkunal changed the title feat(management-client): add userAttributeProfiles & organizations.discoveryDomains, remove groups, refactor client options feat(management-client): add userAttributeProfiles & organizations.discoveryDomains, remove groups, refactor client options (DON Oct 23, 2025
@developerkunal developerkunal changed the title feat(management-client): add userAttributeProfiles & organizations.discoveryDomains, remove groups, refactor client options (DON feat(management-client): add userAttributeProfiles & organizations.discoveryDomains, remove groups, refactor client options (Don't merge) Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 99.64974% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.34%. Comparing base (0a56d66) to head (98c37c2).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...urces/jobs/resources/usersImports/client/Client.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
+ Coverage   79.20%   79.34%   +0.14%     
==========================================
  Files         580      507      -73     
  Lines       18155    18482     +327     
  Branches     8617     9053     +436     
==========================================
+ Hits        14379    14664     +285     
- Misses       3776     3818      +42     
Flag Coverage Δ
alltests 79.34% <99.64%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants