Skip to content

Conversation

@B0Y3R-AVA
Copy link
Contributor

@B0Y3R-AVA B0Y3R-AVA commented Sep 24, 2025

Description

Ticket: CP-11830

Please provide:

Ledger Components & Context

  • Created AnimatedIconWithText.tsx component for connection UI with Lottie animations
  • Added connect-waves.json Lottie animation for device scanning
  • Refactored DerivationPathSelector.tsx component (407 line changes)
  • Created LedgerSetupContext.tsx for managing Ledger setup state across screens
  • Removed unused EnhancedLedgerSetup.tsx and LedgerSetupProgress.tsx components
  • Updated component exports in index.ts

Ledger Route Flow (Multi-Step Setup)

  • Created _layout.tsx with LedgerSetupProvider wrapper
  • Created pathSelection.tsx - Derivation path selection screen
  • Created deviceConnection.tsx - Bluetooth device scanning and connection screen
  • Created appConnection.tsx - Ledger app connection and key retrieval screen
  • Created complete.tsx - Success completion screen
  • Removed unused enhancedSetup.tsx route
  • Updated importWallet.tsx to navigate to Ledger flow

UI Assets

  • Added Ledger logo SVG icon to k2-alpine

Bug Fixes & Cleanup

  • Fixed TypeScript export for WalletCreationOptions type in useLedgerWallet.ts
  • Removed unnecessary index.tsx redirect
  • Cleaned up unused deprecated routes (confirmAddresses.tsx, connectWallet.tsx)
  • Updated navigation flow to skip redirect and go directly to path selection

Screenshots/Videos

Include relevant screenshots or screen recordings of iOS and Android.

Screen.Recording.2025-11-05.at.4.29.17.PM.mov

Testing

Dev Testing (if applicable)

  • Provide steps to test the happy path of your feature
  • Provide steps to test edge cases and error states
  • Trigger a build on bitrise and reference it here
  • Move the ticket into the "Testing" column on Jira

QA Testing (if applicable)

  • Provide instructions for QA to test this feature thoroughly
  • State expected behavior / acceptance criteria

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have included screenshots / videos of android and ios
  • I have added testing steps
  • I have added/updated necessary unit tests
  • I have updated the documentation

@B0Y3R-AVA B0Y3R-AVA changed the base branch from main to boyer/ledger-discovery September 24, 2025 21:47
@B0Y3R-AVA B0Y3R-AVA force-pushed the boyer/ledger-discovery branch 4 times, most recently from 9a64409 to ca26abe Compare October 2, 2025 16:13
Base automatically changed from boyer/ledger-discovery to main October 2, 2025 16:22
@B0Y3R-AVA B0Y3R-AVA force-pushed the boyer/CP-11830-ledger-bluetooth-connect branch 2 times, most recently from 890d0c1 to 229a143 Compare November 6, 2025 15:34
@B0Y3R-AVA B0Y3R-AVA marked this pull request as ready for review November 6, 2025 15:35
@B0Y3R-AVA B0Y3R-AVA force-pushed the boyer/CP-11830-ledger-bluetooth-connect branch from 229a143 to 14a7ec5 Compare November 6, 2025 15:47
@B0Y3R-AVA B0Y3R-AVA force-pushed the boyer/CP-11830-ledger-bluetooth-connect branch from f54f58a to 6ef7f0c Compare November 6, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants