-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Set right UE version to CondaPackages parameter #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mainline
Are you sure you want to change the base?
feat: Set right UE version to CondaPackages parameter #196
Conversation
src/deadline/unreal_submitter/unreal_open_job/unreal_open_job.py
Outdated
Show resolved
Hide resolved
src/deadline/unreal_submitter/unreal_open_job/unreal_open_job.py
Outdated
Show resolved
Hide resolved
Thank you for looking into this. This feature will be extremely helpful for our users. Proposed workflow for this feature:
This will provide maximum flexibility while maintaining proper warnings for users. |
5e34b9d
to
89b5bbe
Compare
Formatting issue detected in unreal_open_job.py by code scanning tool. To resolve:
|
Hey, I've noticed something odd with the UE version detection. I'm running UE 5.5 (though I have 5.4 and 5.6 installed too), but the Could you please take a look again? |
src/deadline/unreal_submitter/unreal_open_job/unreal_open_job.py
Outdated
Show resolved
Hide resolved
Regarding the appearance of 5.6: This value always taken from YAML template and we don't overwrite its content since its our source of truth. But that really strange that there were no warnings. I've got a question: which UE version resulted job has: 5.6 or 5.5? |
Setting a default value for the We still need to keep the default value for script-based job submissions, as it will be used when jobs are submitted programmatically. BTW, pop-up warning dialog is working as expected in UE5.5 and UE5.6. |
3d91b08
to
43f628a
Compare
Small change request. When submitting a job with mis-matched UE version, we first popup a warning asking user if they want to continue. When user click "No", we pop up another error. Please remove the 2nd pop up of error. Screen.Recording.2025-09-19.at.10.54.24.AM.mov |
unreal.AppReturnType.YES, | ||
) | ||
|
||
if result != unreal.AppReturnType.YES: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same feed back as the video recording above. No need to raise error here.
raise exceptions.InvalidUEVersionInCondaPackageParameterNoUI( | ||
"CondaPackages Unreal Engine version mismatch" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest modifying the check_conda_package_version function to return a boolean value. This would make the logic more straightforward:
- Return true to continue job submission
- Return false to stop the process
This approach would make the code more readable and easier to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adressed
Signed-off-by: Ilona Alekseeva <[email protected]>
Signed-off-by: Ilona Alekseeva <[email protected]>
Signed-off-by: e.chernyakov <[email protected]>
Signed-off-by: e.chernyakov <[email protected]>
Signed-off-by: e.chernyakov <[email protected]>
Signed-off-by: e.chernyakov <[email protected]>
Signed-off-by: e.chernyakov <[email protected]>
Signed-off-by: e.chernyakov <[email protected]>
Signed-off-by: e.chernyakov <[email protected]>
…g is dismissed Signed-off-by: e.chernyakov <[email protected]>
Signed-off-by: e.chernyakov <[email protected]>
67a43c0
to
dbd119e
Compare
|
What was the problem/requirement? (What/Why)
It's necessary that CondaPackages parameter should contain same UE version as the version of the project from job is submitted. Therefore the default value define in Template should be updated on submit if its differs
What was the solution? (How)
Add validation of CondaPackages parameter.
What is the impact of this change?
Job can't be submitted with wrong unreal engine conda package version
How was this change tested?
Submit Job without CondaPackages parameter - validation skipped
With empty CondaPackages parameter - unrealengine=x.x were added (5.4)
With CondaPackages=unrealengine=5.3 - raise an error (Project was on 5.4)
With CondaPackages=unrealengine=5.4 - validation passed (Project was on 5.4)
Yes
Have you run a render job successfully with these changes?
Yes
Was this change documented?
Yes
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.