Fix undercounting of awsvpc network stats #4766
Open
+13
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isker
force-pushed
the
fix-ec2-network-stats-undercounting
branch
from
f1694b4 to
2ead5a4
Compare
|
Thanks a lot for reporting the issue and this contribution. We will test your changes, and update here. |
singholt
reviewed
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #4618, it seems that scaling down these network stats by the number of containers is simply incorrect. On that issue, I have empirically compared EC2 awsvpc numbers to both Fargate awsvpc and EC2 bridge numbers to deduce this.
Implementation details
Don't do that division.
Testing
Existing unit tests were updated.
In terms of validating that this is the correct change, all I have is comparative analysis against existing behaviors of Fargate and EC2 with bridge networking. The only other way I can think to test this is to deploy this to a real EC2 instance and repeat the testing procedure discussed in #4618. I can find no documentation in this project on how to do this. I would appreciate your advice.
New tests cover the changes: no.
Description for the changelog
Bug - Fix undercounting of network stats when using the awsvpc networking mode.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No.
Does this PR include the addition of new environment variables in the README?
No.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.