Skip to content

Conversation

@kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Aug 6, 2025

This PR includes the following:

  • more robust trace messaging for telemetry success / failure
  • use of Funnel class to combine FileSink and EndpointSink
  • update integ tests to assert on trace messages that the telemetry sent returns 200 OK
  • integ tests of the official endpoint (or the endpoint supplied in TELEMETRY_ENDPOINT)

When merged and released, this PR launches cdk cli telemetry


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 6, 2025 18:57
@kaizencc kaizencc changed the title feat: telemetry sent to endpoint feat(cli): telemetry sent to endpoint Aug 6, 2025
Signed-off-by: github-actions <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 68.75000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.81%. Comparing base (29a6178) to head (aa6fc7e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/io-host/cli-io-host.ts 73.52% 9 Missing ⚠️
...es/aws-cdk/lib/cli/telemetry/sink/endpoint-sink.ts 66.66% 4 Missing ⚠️
...ges/aws-cdk/lib/cli/telemetry/collect-telemetry.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
+ Coverage   84.50%   84.81%   +0.30%     
==========================================
  Files          71       72       +1     
  Lines       10445    10469      +24     
  Branches     1344     1350       +6     
==========================================
+ Hits         8827     8879      +52     
+ Misses       1577     1551      -26     
+ Partials       41       39       -2     
Flag Coverage Δ
suite.unit 84.81% <68.75%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kaizencc kaizencc deployed to integ-approval November 20, 2025 18:10 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants