fix(ec2): remove PassRole policy emitted by cloudwatch vpc flow destination #35762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abogical
added
the
pr/needs-integration-tests-deployment
Abogical
had a problem deploying
to
deployment-integ-test
GitHub Actions
Failure
github-actions
bot
added
p2
admired-contributor
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Abogical
force-pushed
the
vpc-flow-remove-pass-role
branch
from
8a9b750 to
ac73f2e
Compare
Abogical
had a problem deploying
to
deployment-integ-test
GitHub Actions
Failure
Abogical
had a problem deploying
to
deployment-integ-test
GitHub Actions
Error
aws-cdk-automation
added
the
pr/needs-maintainer-review
aws-cdk-automation
requested a deployment
to
deployment-integ-test
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Related to #35729.
Reason for this change
A PassRole policy is created whenever a cloudwatch destination is setup for a VPC flow destination. This is not needed as indicated from the VPC flow docs.
Description of changes
Removed policy.
Describe any new or updated permissions being added
PassRole policy is removed.
Description of how you validated changes
Unit tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license