Skip to content

Conversation

@Abogical
Copy link
Member

Reason for this change

For integration deployment tests, accounts under atmosphere do not have the CDK bootstrap.

Description of changes

Add a bootstrap step to the integration deployment test.

Describe any new or updated permissions being added

No new IAM permissions added.

Description of how you validated changes

Workflow runs successfully under fork: https://github.com/Abogical/aws-cdk/actions/runs/18687737855/job/53284876440

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Oct 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 21, 2025 15:10
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 21, 2025
Copy link
Contributor

@kumvprat kumvprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions :

  • Why not bootstrap these accounts from start and avoid the whole bootstraping for each integ test?
  • Is there a way to check if the account is already bootstrapped and avoid executing this command ?

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 22, 2025
@Abogical
Copy link
Member Author

Abogical commented Oct 22, 2025

@kumvprat

Couple of questions :

  • Why not bootstrap these accounts from start and avoid the whole bootstraping for each integ test?
  • Is there a way to check if the account is already bootstrapped and avoid executing this command ?
  • Atmosphere is supposed to remove the bootstrap from the account automatically when it is deallocated.
  • Yes, however the cost is minimal even if we try to deploy the bootstrap again. As cloudfromation will detect that the stack is already deployed and won't do anything.

Copy link
Contributor

@kumvprat kumvprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--disable-update-workflow seems to be a requirement since the integ runner looks for main branch 🤷

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 22, 2025
@Abogical
Copy link
Member Author

FYI on --disable-update-workflow: The update workflow did not work as the integ runner does not find the 'main' branch within the workflow environment. See this example in the logs of a previous run: https://github.com/Abogical/aws-cdk/actions/runs/18650693435/job/53281026995#step:13:212

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added dequeued and removed queued labels Oct 22, 2025
@Abogical
Copy link
Member Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

rebase

✅ Branch has been successfully rebased

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added queued and removed dequeued labels Oct 22, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 22, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 48e05d5 into main Oct 22, 2025
35 of 37 checks passed
@mergify mergify bot deleted the integ-bootstrap branch October 22, 2025 16:05
@mergify mergify bot removed the queued label Oct 22, 2025
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants