-
Notifications
You must be signed in to change notification settings - Fork 4.3k
ci(integration-test-deployment): bootstrap account before deployment #35799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions :
- Why not bootstrap these accounts from start and avoid the whole bootstraping for each integ test?
- Is there a way to check if the account is already bootstrapped and avoid executing this command ?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
--disable-update-workflow seems to be a requirement since the integ runner looks for main branch 🤷
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
FYI on |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You may have to fix your CI before adding the pull request to the queue again. |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
f17af53 to
0111c9f
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
For integration deployment tests, accounts under atmosphere do not have the CDK bootstrap.
Description of changes
Add a bootstrap step to the integration deployment test.
Describe any new or updated permissions being added
No new IAM permissions added.
Description of how you validated changes
Workflow runs successfully under fork: https://github.com/Abogical/aws-cdk/actions/runs/18687737855/job/53284876440
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license