Skip to content

Conversation

justsmth
Copy link
Contributor

Issues:

Addresses: #849 (comment)

Description of changes:

Allows the encoding of a ParsedPublicKey into an X509 public key.

Call-outs:

verify_sig and verify_digest_sig in RsaParameters was assuming an RFC8017 encoded public key. I don't see any reason that it should not also accept X509.

Testing:

Updated tests to provide coverage.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner September 19, 2025 13:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.35%. Comparing base (c358484) to head (31547d0).
⚠️ Report is 260 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/rsa/signature.rs 0.00% 0 Missing and 2 partials ⚠️
aws-lc-rs/src/signature.rs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
- Coverage   95.80%   92.35%   -3.45%     
==========================================
  Files          61       73      +12     
  Lines        8143     9638    +1495     
  Branches        0     9638    +9638     
==========================================
+ Hits         7801     8901    +1100     
- Misses        342      450     +108     
- Partials        0      287     +287     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the x509-parsed-public-key branch from ea928dc to 31547d0 Compare September 23, 2025 12:47
@justsmth justsmth mentioned this pull request Sep 23, 2025
@justsmth justsmth merged commit 4f45d3d into aws:main Sep 23, 2025
308 of 311 checks passed
@justsmth justsmth deleted the x509-parsed-public-key branch September 23, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants