Uncap HKDF salt length restriction #951
Open
+47
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
force-pushed
the
hkdf-uncap-salt
branch
from
cbc7128 to
47329ec
Compare
skmcgrail
force-pushed
the
hkdf-uncap-salt
branch
from
47329ec to
79377fb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
==========================================
- Coverage 95.80% 92.53% -3.27%
==========================================
Files 61 74 +13
Lines 8143 9855 +1712
Branches 0 9855 +9855
==========================================
+ Hits 7801 9119 +1318
- Misses 342 449 +107
- Partials 0 287 +287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skmcgrail
force-pushed
the
hkdf-uncap-salt
branch
from
79377fb to
e9f3653
Compare
torben-hansen
approved these changes
Nov 15, 2025
justsmth
reviewed
Nov 17, 2025
Comment on lines
129
to
+136
| pub fn new(algorithm: Algorithm, value: &[u8]) -> Self { | ||
| Salt::try_new(algorithm, value).expect("Salt length limit exceeded.") | ||
| Salt::try_new(algorithm, value).expect("Failed to create Salt") | ||
| } | ||
|
|
||
| #[allow(clippy::unnecessary_wraps)] | ||
| fn try_new(algorithm: Algorithm, value: &[u8]) -> Result<Salt, Unspecified> { | ||
| let salt_len = value.len(); | ||
| if salt_len > MAX_HKDF_SALT_LEN { | ||
| return Err(Unspecified); | ||
| } | ||
| let mut salt_bytes = [0u8; MAX_HKDF_SALT_LEN]; | ||
| salt_bytes[0..salt_len].copy_from_slice(value); | ||
| Ok(Self { | ||
| algorithm, | ||
| bytes: salt_bytes, | ||
| len: salt_len, | ||
| }) | ||
| let bytes = value.to_vec().into_boxed_slice(); | ||
| Ok(Self { algorithm, bytes }) |
Contributor
There was a problem hiding this comment.
I don't think try_new is needed now that we have no effective limit, we can just move this implementation into new.
Comment on lines
+105
to
106
| // Box<[u8]> implements Zeroize, so we can call it directly | ||
| self.bytes.zeroize(); |
Contributor
There was a problem hiding this comment.
NP: I think the Salt is a public value, so I'm not sure this is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Remove the salt length restriction for HKDF operations by moving the salt bytes field to be a Box'd value.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.