Fix try_compile usage #2626
Closed
Fix try_compile usage #2626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2626 +/- ##
=======================================
Coverage 78.83% 78.83%
=======================================
Files 667 667
Lines 114077 114077
Branches 16045 16047 +2
=======================================
+ Hits 89932 89934 +2
+ Misses 23370 23369 -1
+ Partials 775 774 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
force-pushed
the
fix-cmake-try-compile
branch
from
530f409 to
eaa9053
Compare
torben-hansen
previously approved these changes
Sep 11, 2025
### Issues: n/a ### Description of changes: see title ### Call-outs: n/a ### Testing: ``` $ export JAVA_HOME=/usr/lib/jvm/default-java/ TEST_JAVA_HOME=$JAVA_HOME ACCP_FIPS=true $ ./tests/ci/integration/run_accp_integration.sh ... [PENDING] ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
### Issues: N/A - Update for password handling compatibility ### Description of changes: Currently, AWS-LC rejects zero-length passwords in PEM key decryption by using '<= 0' validation in both EVP_read_pw_string_min and PEM_read_bio_PrivateKey functions. This differs from OpenSSL behavior and prevents proper interactive password prompting. This change modifies the password length validation from '<= 0' to '< 0' in: - crypto/fipsmodule/evp/evp.c: EVP_read_pw_string_min function - crypto/pem/pem_pkey.c: PEM_read_bio_PrivateKey function This enables proper interactive password prompting when no password is provided via -passin, allowing users to enter empty passwords or be prompted interactively for encrypted PEM keys, matching OpenSSL behavior. ### Call-outs: This is a minimal change that only affects password length validation logic. The change maintains backward compatibility while enabling OpenSSL-compatible behavior for zero-length passwords. ### Testing: The change has been tested to ensure that: - Zero-length passwords are now accepted - Interactive password prompting works correctly - Existing functionality remains unaffected By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. Co-authored-by: kingstjo <[email protected]>
Use CheckCCompilerFlag to test support for -Wno-cast-function-type before use.
### Description of changes: Mainly reorganizes the project to have the x509-limbo and python dependency already setup in a docker container (which will stay updates by our periodic pipeline refreshment). We then use the image and pull in the AWS-LC source and run the harness within that. ### Testing: Verified the changes work with the X509 CodeBuild webhook project. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Prepare AWS-LC v1.61.0.
### Description of changes: For MSVC, the `/FI` option should be used for force-includes: https://learn.microsoft.com/en-us/cpp/build/reference/fi-name-forced-include-file?view=msvc-170 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
### Description of changes: Add more arm64 build targets to our CI. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
### Description of changes: Modified the name of the duplicate ACCP tests to fix CI failures By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The documentation around
COMPILE_DEFINITIONSandtry_compileseems inconsistent with how we are using it.CMAKE_FLAGSinstead.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.