Implement dgst CLI command #2638
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2638 +/- ##
==========================================
+ Coverage 78.83% 78.89% +0.06%
==========================================
Files 667 667
Lines 114077 114332 +255
Branches 16045 16085 +40
==========================================
+ Hits 89932 90203 +271
+ Misses 23370 23349 -21
- Partials 775 780 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
Aug 27, 2025
justsmth
reviewed
Aug 27, 2025
tool-openssl/dgst.cc
Outdated
Comment on lines
383
to
386
| for (size_t i = 0; i < data.size(); i++) { | ||
| BIO_printf(out_bio.get(), "%02x", data[i]); | ||
| } | ||
| BIO_printf(out_bio.get(), "\n"); |
There was a problem hiding this comment.
Could you just use BIO_hexdump here?
There was a problem hiding this comment.
No unfortunately. We need a raw hex dump but BIO_hexdump has a special formatting that looks something like this -- OFFSET HEX_BYTES |ASCII|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #CryptoAlg-3383
Description of changes:
Re-implement dgst cli commands with the following options:
-binary
-sha256 (and a handful of other digest algorithms)
-sigopt
-passin
-sign
-out
-verify
-signature
-keyform
Call-outs:
Waiting for #2555 to implement
-passinTesting:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.