Add minimal EC CLI tool implementation #2640
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create ec.cc with EC-specific key processing - Support options: -inform, -in, -pubout, -out, -outform - Handle PEM/DER format conversion for EC private/public keys - Use EC-specific AWS-LC APIs for proper key handling - Integrate ecTool into build system (CMakeLists.txt, internal.h, tool.cc) - Tested format conversion and OpenSSL interoperability Assisted by Amazon Q
- Create ec_test.cc with cross-compatibility testing - Test all minimal EC options: -inform, -in, -pubout, -out, -outform - Include format conversion tests (PEM/DER) and round-trip validation - Add error handling tests for invalid inputs/outputs - Support conditional OpenSSL cross-compatibility when env vars set - Use BIO pattern consistent with other AWS-LC tool tests - All 13 tests pass including OpenSSL interoperability validation Assisted by Amazon Q
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2640 +/- ##
==========================================
+ Coverage 78.81% 78.82% +0.01%
==========================================
Files 667 669 +2
Lines 113982 114138 +156
Branches 16028 16040 +12
==========================================
+ Hits 89835 89972 +137
- Misses 23374 23391 +17
- Partials 773 775 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #CryptoAlg-3382
Description of changes:
This PR implements a minimal EC CLI tool for AWS-LC to provide EC key processing capabilities similar to OpenSSL's
openssl eccommand. The tool supports essential EC key operations including format conversion between PEM/DER for both private and public keys, using AWS-LC's native EC APIs for proper key handling.Testing:
ec_test.cccovering:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.