Add new CI dimension for legacy AVX flags and run tests #2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2679 +/- ##
==========================================
- Coverage 78.83% 78.83% -0.01%
==========================================
Files 667 667
Lines 114077 114077
Branches 16046 16046
==========================================
- Hits 89935 89928 -7
- Misses 23365 23375 +10
+ Partials 777 774 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samuel40791765
added a commit
that referenced
this pull request
Sep 18, 2025
There were some issues with the 32-bit build run in #2679, this attempts to resolve that. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
AWS-LC-902Description of changes:
We were previously only running the build, but not tests when options MY_ASSEMBLER_IS_TOO_OLD_FOR_512AVX or MY_ASSEMBLER_IS_TOO_OLD_FOR_AVX were enabled. This PR moves this testing to its own dimension and enables running the tests.
Instead of the "run_tests" target, when GO is disabled, "run_tests_minimal" is produced. Refactors to support this.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.