Skip to content

Conversation

alexw91
Copy link
Contributor

@alexw91 alexw91 commented Sep 12, 2025

Issues:

Description of changes:

Fixes tests that assume X25519 will be negotiated and will break when the default TLS supported group is changed to X25519MLKEM768.

Related to https://github.com/aws/aws-lc/pull/2531/files

Call-outs:

None

Testing:

Unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@alexw91 alexw91 requested a review from a team as a code owner September 12, 2025 21:27
@alexw91 alexw91 force-pushed the pq-by-default-tests branch 5 times, most recently from 7ca04f2 to cccb434 Compare September 12, 2025 22:55
@alexw91 alexw91 force-pushed the pq-by-default-tests branch from cccb434 to b832653 Compare September 12, 2025 23:12
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.83%. Comparing base (5f1d0d2) to head (b832653).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ssl/ssl_version_test.cc 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2682      +/-   ##
==========================================
- Coverage   78.83%   78.83%   -0.01%     
==========================================
  Files         667      667              
  Lines      114077   114089      +12     
  Branches    16046    16046              
==========================================
+ Hits        89935    89937       +2     
- Misses      23365    23378      +13     
+ Partials      777      774       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants