feat: minor version strategy rules #1687

0marperez · 2025-09-16T21:48:06Z

Issue #

N/A

Description of changes

Configure minor-version-strategy rules (deprecatedUntilVersion)
GH workflow to run new rule

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lauzadis

I don't like that every project now needs to define a ktlint-rules module. Can we move the rule registration to aws-kotlin-repo-tools? We already have a reference to the Gradle Project there and should be able to get the sdkVersion and anything else you need

lauzadis · 2025-09-17T13:19:44Z

...otlin/aws/sdk/kotlin/ktlintrules/minorversionstrategy/MinorVersionStrategyRuleSetProvider.kt

+ * Ruleset provider for AWS SDK Kotlin minor-version-bump-specific Ktlint rules.
+ */
+class MinorVersionStrategyRuleSetProvider : RuleSetProviderV3(RuleSetId("minor-version-strategy-rules")) {
+    private val sdkVersion = System.getProperty("sdkVersion").split(".")


correctness: this looks at JVM system properties, not Gradle properties right?

Correct, I don't think we can access gradle.properties at runtime unless we explicitly read the file. We're setting the Gradle property as a system property here.

Oh I missed that, I'm not a fan of that approach but I'm not sure there's anything better

0marperez · 2025-09-17T14:58:20Z

I don't like that every project now needs to define a ktlint-rules module. Can we move the rule registration to aws-kotlin-repo-tools? We already have a reference to the Gradle Project there and should be able to get the sdkVersion and anything else you need

We can't move it to repo tools because the rule would need to be published and then consumed downstream i.e. the minor and major version would be hardcoded. We can access the minor and major version using the Project, but rule registration can't be done in the build.gradle.kts file downstream.

lauzadis · 2025-09-17T15:06:47Z

build.gradle.kts

+configureMinorVersionStrategyRules(lintPaths)
+
+// Set SDK version from gradle.properties as a system property for 'configureMinorVersionStrategyRules' to use
+tasks.withType<JavaExec> {


this can be refined to only a single task using tasks.named("...")

lauzadis · 2025-09-17T15:07:18Z

...otlin/aws/sdk/kotlin/ktlintrules/minorversionstrategy/MinorVersionStrategyRuleSetProvider.kt

+ * Ruleset provider for AWS SDK Kotlin minor-version-bump-specific Ktlint rules.
+ */
+class MinorVersionStrategyRuleSetProvider : RuleSetProviderV3(RuleSetId("minor-version-strategy-rules")) {
+    private val sdkVersion = System.getProperty("sdkVersion").split(".")


Oh I missed that, I'm not a fan of that approach but I'm not sure there's anything better

github-actions · 2025-09-18T20:57:46Z