Skip to content

chore(ci): add GH workflow for service check batch and e2e tests #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2022
Merged

chore(ci): add GH workflow for service check batch and e2e tests #713

merged 2 commits into from
Oct 4, 2022

Conversation

aajtodd
Copy link
Contributor

@aajtodd aajtodd commented Oct 3, 2022 •
edited
Loading

Issue #

N/A

Description of changes

  • Update default region used in E2E tests to be consistent
  • Add new GH workflow to migrate service check batch job to a GH action that kicks off codebuild job rather than using CodeBuild's webhook trigger
    • NOTE: This may one day make it into the aws-codebuild-run-build action but that PR hasn't seen any traction in over 2 years it would seem. For now I've added a simple wrapper script
  • Add new e2e test workflow that runs all the e2e tests defined in our project. This has corresponding infrastructure setup and IAM policies that allow the invoked codebuild job to run these tests. Additions/modifications of e2e tests will potentially require corresponding infrastructure changes/deployment.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aajtodd aajtodd changed the title chore(ci): chore(ci): add GH workflow for service check batch and e2e tests Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

A new generated diff is ready to view: __generated-main...__generated-e2etests

@aajtodd aajtodd added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

A new generated diff is ready to view: __generated-main...__generated-e2etests

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

A new generated diff is ready to view: __generated-main...__generated-e2etests

@aajtodd aajtodd marked this pull request as ready for review October 3, 2022 18:04
@aajtodd aajtodd requested a review from a team as a code owner October 3, 2022 18:04
lauzadis
lauzadis approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@lauzadis lauzadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ianbotsf
ianbotsf approved these changes Oct 3, 2022
View reviewed changes
.github/scripts/runCodeBuildBatchJob.sh
Comment on lines 24 to 26
if [ "$?" != "0" ]; then
error_exit "Could not start project. Exiting."
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: Should probably echo START_RESULT here in case there's anything useful for debugging.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

A new generated diff is ready to view: __generated-main...__generated-e2etests

@aajtodd aajtodd merged commit bddae31 into main Oct 4, 2022
@aajtodd aajtodd deleted the e2etests branch October 4, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lauzadis lauzadis lauzadis approved these changes

@ianbotsf ianbotsf ianbotsf approved these changes

+1 more reviewer

@lucix-aws lucix-aws lucix-aws approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aajtodd @lauzadis @ianbotsf @lucix-aws