Skip to content

Honor EncodingType in response with ListObjectsV2 as with ListObjects #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Honor EncodingType in response with ListObjectsV2 as with ListObjects #2918

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2908f47
Honor EncodingType in response with ListObjectsV2 as with ListObjects
nanawel May 9, 2024
b090e50
Merge branch 'aws:master' into fix-listobjectsv2-honor-encodingtype
nanawel Jun 13, 2024
9772ebc
Merge branch 'aws:master' into fix-listobjectsv2-honor-encodingtype
nanawel Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/S3/S3Client.php
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you either turn this test into a parameterized test which call both listObjects and listObjectsV2 or create a separate unit test for listObjectsV2?

Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,7 @@ private function getEncodingTypeMiddleware()
return static function (callable $handler) {
return function (Command $command, $request = null) use ($handler) {
$autoSet = false;
if ($command->getName() === 'ListObjects'
if (strpos($command->getName(), 'ListObjects') === 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to a str_starts_with()?

&& empty($command['EncodingType'])
) {
$command['EncodingType'] = 'url';
Expand Down