-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: s3 transfer manager v2 #3079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yenfryherrerafeliz
wants to merge
62
commits into
aws:master
Choose a base branch
from
yenfryherrerafeliz:feat_s3_transfer_manager_v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14,334
−213
Open
Changes from 46 commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
3093732
feat: s3 transfer manager v2
yenfryherrerafeliz 5950c31
chore: add tests cases and refactor
yenfryherrerafeliz 1c82ab5
chore: add multipart download listener tests
yenfryherrerafeliz 237fc7b
chore: refactor multipart downloaders and add tests
yenfryherrerafeliz c28c165
feat: add download directory and refactor code
yenfryherrerafeliz 34321b2
chore: add upload and refactor code
yenfryherrerafeliz 5289f7c
feat: add upload directory feature
yenfryherrerafeliz c6c0780
feat: multipart upload and some refactor
yenfryherrerafeliz 034b50d
chore: short namespace
yenfryherrerafeliz bc15ac3
chore: refactor and address feedback
yenfryherrerafeliz e681d10
chore: fix test cases
yenfryherrerafeliz 1f094cd
chore: remove unused implementation
yenfryherrerafeliz 464b498
chore: remove invalid test
yenfryherrerafeliz 09e493f
fix: add nullable type
yenfryherrerafeliz f10522b
chore: add more tests
yenfryherrerafeliz a55e1b3
chore: add upload unit tests and refactor
yenfryherrerafeliz b271897
chore: address naming feedback and test failures
yenfryherrerafeliz f4f1c88
chore: address minor styling issues
yenfryherrerafeliz d987aff
chore: add download tests
yenfryherrerafeliz 6d000f1
chore: add integ tests
yenfryherrerafeliz 27570d0
chore: add integ test
yenfryherrerafeliz 1dde7fc
chore: address PR feedback
yenfryherrerafeliz 060e0e1
chore: fix and refactor
yenfryherrerafeliz ee0fefb
chore: fix TransferListener import
yenfryherrerafeliz 9f639f1
chore: add test case
yenfryherrerafeliz bdce369
chore: address PR feedback
yenfryherrerafeliz cd2133a
fix: prevent calling twice downloadFailed
yenfryherrerafeliz 0426e11
chore: fix exception throwing
yenfryherrerafeliz a548ce2
feat: consider checksum mode from command
yenfryherrerafeliz 5a25ad8
chore: tests and minor fixes
yenfryherrerafeliz 64fc3f6
tests: Add integ test for abort
yenfryherrerafeliz 908b4a0
chore: update integ test
yenfryherrerafeliz 1e643e5
feat: update to use modeled inputs
yenfryherrerafeliz 48a2822
chore: multipart download updates
yenfryherrerafeliz 02b43f0
chore: s3 transfer manager updates
yenfryherrerafeliz 153227b
chore: minor update
yenfryherrerafeliz 31dbd19
chore: add empty lines at the end
yenfryherrerafeliz aeed758
chore: remove unused implementations
yenfryherrerafeliz 26d2469
fix: object key should be normalized
yenfryherrerafeliz 10928ca
fix: minor logic and test fix
yenfryherrerafeliz 632ece9
fix: fix s3 delimiter test
yenfryherrerafeliz 6efcc0a
fix: wrong data provider name used
yenfryherrerafeliz b0c5f75
chore: addressed some styling
yenfryherrerafeliz 44f6ff4
chore: update argument name
yenfryherrerafeliz 83ccd9b
chore: make config optional
yenfryherrerafeliz 039a67b
chore: minor refactor and fix
yenfryherrerafeliz 50715d1
chore: make parameter optional
yenfryherrerafeliz 3034ad8
chore: make model classes final
yenfryherrerafeliz cfe4ab5
chore: make classes final and refactor tests
yenfryherrerafeliz f4c42e0
chore: fix and reformat integ test
yenfryherrerafeliz 9fb03f1
chore: address some styling suggestions
yenfryherrerafeliz 4268266
chore: address PR suggestions
yenfryherrerafeliz 59a8aa4
chore: null as default
yenfryherrerafeliz 45ac289
chore: use UploadRequest construct
yenfryherrerafeliz 20ada71
chore: address PR feedback
yenfryherrerafeliz e7842ed
chore: minor tests fix
yenfryherrerafeliz 7c52a2f
enhancement: tests and fixes
yenfryherrerafeliz fa664b1
fix: tests with part count
yenfryherrerafeliz d2d4688
fix: test invalid checksum
yenfryherrerafeliz e6a141f
chore: address PR feedback
yenfryherrerafeliz e80eeff
chore: address some PR feedback
yenfryherrerafeliz ec383d2
chore: some minor refactor
yenfryherrerafeliz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenfryherrerafeliz marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
@s3-transfer-manager @integ | ||
Feature: S3 Transfer Manager | ||
S3 Transfer Manager should successfully do: | ||
- object uploads | ||
- object multipart uploads | ||
- object downloads | ||
- object multipart downloads | ||
- directory object uploads | ||
- directory object downloads | ||
|
||
Scenario Outline: Successfully does a single file upload | ||
Given I have a file <filename> with content <content> | ||
When I upload the file <filename> to a test bucket using the s3 transfer manager | ||
Then the file <filename> should exist in the test bucket and its content should be <content> | ||
|
||
Examples: | ||
| filename | content | | ||
| myfile-test-1-1.txt | Test content #1 | | ||
| myfile-test-1-2.txt | Test content #2 | | ||
| myfile-test-1-3.txt | Test content #3 | | ||
|
||
|
||
Scenario Outline: Successfully does a single upload from a stream | ||
Given I have a stream with content <content> | ||
When I do the upload to a test bucket with key <key> | ||
Then the object <key>, once downloaded from the test bucket, should match the content <content> | ||
Examples: | ||
| content | key | | ||
| "This is a test text - 1" | myfile-test-2-1.txt | | ||
| "This is a test text - 2" | myfile-test-2-2.txt | | ||
| "This is a test text - 3" | myfile-test-2-3.txt | | ||
|
||
Scenario Outline: Successfully do multipart object upload from file | ||
Given I have a file with name <filename> where its content's size is <filesize> | ||
When I do upload this file with name <filename> with the specified part size of <partsize> | ||
Then the object with name <filename> should have a total of <partnum> parts and its size must be <filesize> | ||
Examples: | ||
| filename | filesize | partsize | partnum | | ||
| myfile-test-3-1.txt | 10485760 | 5242880 | 2 | | ||
| myfile-test-3-2.txt | 24117248 | 5242880 | 5 | | ||
| myfile-test-3-3.txt | 24117248 | 8388608 | 3 | | ||
|
||
Scenario Outline: Successfully do multipart object upload from streams | ||
Given I have want to upload a stream of size <filesize> | ||
When I do upload this stream with name <filename> and the specified part size of <partsize> | ||
Then the object with name <filename> should have a total of <partnum> parts and its size must be <filesize> | ||
Examples: | ||
| filename | filesize | partsize | partnum | | ||
| myfile-test-4-1.txt | 10485760 | 5242880 | 2 | | ||
| myfile-test-4-2.txt | 24117248 | 5242880 | 5 | | ||
| myfile-test-4-3.txt | 24117248 | 8388608 | 3 | | ||
|
||
Scenario Outline: Does single object upload with custom checksum | ||
Given I have a file with name <filename> and its content is <content> | ||
When I upload this file with name <filename> by providing a custom checksum algorithm <checksum_algorithm> | ||
Then the checksum from the object with name <filename> should be equals to the calculation of the object content with the checksum algorithm <checksum_algorithm> | ||
Examples: | ||
| filename | content | checksum_algorithm | | ||
| myfile-test-5-1.txt | This is a test file content #1 | crc32 | | ||
| myfile-test-5-2.txt | This is a test file content #2 | crc32c | | ||
| myfile-test-5-3.txt | This is a test file content #3 | sha256 | | ||
| myfile-test-5-4.txt | This is a test file content #4 | sha1 | | ||
|
||
Scenario Outline: Does single object download | ||
Given I have an object in S3 with name <filename> and its content is <content> | ||
When I do a download of the object with name <filename> | ||
Then the object with name <filename> should have been downloaded and its content should be <content> | ||
Examples: | ||
| filename | content | | ||
| myfile-test-6-1.txt | This is a test file content #1 | | ||
| myfile-test-6-2.txt | This is a test file content #2 | | ||
| myfile-test-6-3.txt | This is a test file content #3 | | ||
|
||
Scenario Outline: Successfully does multipart object download | ||
Given I have an object in S3 with name <filename> and its size is <filesize> | ||
When I download the object with name <filename> by using the <download_type> multipart download type | ||
Then the content size for the object with name <filename> should be <filesize> | ||
Examples: | ||
| filename | filesize | download_type | | ||
| myfile-test-7-1.txt | 20971520 | rangeGet | | ||
| myfile-test-7-2.txt | 28311552 | rangeGet | | ||
| myfile-test-7-3.txt | 12582912 | rangeGet | | ||
| myfile-test-7-4.txt | 20971520 | partGet | | ||
| myfile-test-7-5.txt | 28311552 | partGet | | ||
| myfile-test-7-6.txt | 12582912 | partGet | | ||
|
||
Scenario Outline: Successfully does directory upload | ||
Given I have a directory <directory> with <numfile> files that I want to upload | ||
When I upload this directory <directory> | ||
Then the files from this directory <directory> where its count should be <numfile> should exist in the bucket | ||
Examples: | ||
| directory | numfile | | ||
| directory-test-1-1 | 10 | | ||
| directory-test-1-2 | 3 | | ||
| directory-test-1-3 | 25 | | ||
| directory-test-1-4 | 1 | | ||
|
||
Scenario Outline: Successfully does a directory download | ||
Given I have a total of <numfile> objects in a bucket prefixed with <directory> | ||
When I download all of them into the directory <directory> | ||
Then the objects <numfile> should exist as files within the directory <directory> | ||
Examples: | ||
| numfile | directory | | ||
| 15 | directory-test-2-1 | | ||
| 12 | directory-test-2-2 | | ||
| 1 | directory-test-2-3 | | ||
| 30 | directory-test-2-4 | | ||
|
||
Scenario Outline: Abort a multipart upload | ||
Given I am uploading the file <file> with size <size> | ||
When I upload the file <file> using multipart upload and fails at part number <partNumberFail> | ||
Then The multipart upload should have been aborted for file <file> | ||
Examples: | ||
| file | size | partNumberFail | | ||
| abort-file-1.txt | 1024 * 1024 * 20 | 3 | | ||
| abort-file-2.txt | 1024 * 1024 * 40 | 5 | | ||
| abort-file-3.txt | 1024 * 1024 * 10 | 1 | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.