Skip to content

Conversation

@kmcginnes
Copy link
Collaborator

Description

This change fixes an issue where the request signing would not properly merge the original request and the signed request. This resulted in certain headers and request options left out of the final request that is sent to the database.

I've also reorganized the code and added a bevy of tests around the request signing.

Validation

  • Tested against Neptune with IAM enabled
  • Tested against public RDF endpoint

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review September 11, 2025 01:08
@kmcginnes kmcginnes force-pushed the sparql/iam-auth branch 2 times, most recently from 75c7926 to 0a9f9d1 Compare September 15, 2025 20:12
@kmcginnes kmcginnes changed the title Enhance request signing in proxy server Refactor request signing in proxy server Sep 22, 2025
@kmcginnes kmcginnes changed the title Refactor request signing in proxy server Fix header forwarding in request signing in proxy server Sep 22, 2025
@kmcginnes kmcginnes marked this pull request as draft September 22, 2025 22:19
@kmcginnes
Copy link
Collaborator Author

Marking as draft. While the bulk of this change is still good, I have some other cleanup to do first. And this is not required for the SPARQL query editor work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some headers are not forwarded to database request from proxy server

1 participant