update xgboost from 1.7-1 to 1.7-1-1 #5285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxning
requested a deployment
to
manual-approval
GitHub Actions
Waiting
| model_server=ModelServer.TORCHSERVE, | ||
| schema_builder=SchemaBuilder(X_test, y_pred), | ||
| image_uri="123123123123.dkr.ecr.ap-southeast-2.amazonaws.com/byoc-image:xgb-1.7-1") | ||
| image_uri="123123123123.dkr.ecr.ap-southeast-2.amazonaws.com/byoc-image:xgb-1.7-1-1") |
There was a problem hiding this comment.
this is not our image seems like some byoc usecase.
| @pytest.fixture | ||
| def xgb_user_settings(sagemaker_session, base_user_settings): | ||
| base_user_settings["image"] = image_uris.retrieve( | ||
| "xgboost", sagemaker_session._region_name, "1.7-1", "py38" |
There was a problem hiding this comment.
the reason why I don't know this code change is needed or not is because this is still on Py38 and not on the current version of python in the container which is 39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
update xgboost from 1.7-1 to 1.7-1-1
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.