Added payload format version 2 blueprints for Node.js and Python #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MynockSpit
reviewed
Sep 9, 2020
| * @class AuthPolicy | ||
| * @constructor | ||
| */ | ||
| function AuthPolicy(principal, awsAccountId, apiOptions) { |
There was a problem hiding this comment.
This shouldn't be a class -- it only serves to make it confusing. I realize you copy-pasted it, but we really should refactor this out into something clearer (so users read it easier to learn how to make a policy) and simpler (so that it takes less effort to learn).
This could be as simple as a function with this signature.
function createPolicy(principal, awsAccountId, region, stage, apiId, allowedRoutes) {
// maps through the provided routes and returns a policy that allows only them
}| } | ||
|
|
||
| if (!this.pathRegex.test(resource)) { | ||
| throw new Error("Invalid resource path: " + resource + ". Path should match " + this.pathRegex); |
There was a problem hiding this comment.
Did you test to confirm that it uses route and not routeKey?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Forked existing Node.js and Python blueprints into payload format versions v1 and v2 samples
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Confirmed