-
Notifications
You must be signed in to change notification settings - Fork 29
chore: its factory commands update #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aa59961
to
13189da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 2 comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that we get rid of the --action
option in favor of separate commands. Though in my opinion the sequence of 5+ unnaed arguments makes it harder to read the commands.
update the release template document |
19aa9d6
to
7b8ffa5
Compare
…erchain-token-deploy-salt
e24987e
to
cfc1f9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that now we use the required options instead of pos args. I left comments related to removing the args completely, other than that it looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thank you for all the updates!
why?
ITS Factory script commands and ITS script commands are written out differently. Makes it inconsistent to run the two scripts
how?
Refactored ITS Factory commands to match ITS script commands
testing
Tested each command and added an example for how to run each command in the README
Greptile Overview
Updated On: 2025-09-26 20:12:39 UTC
Summary
This PR refactors the Interchain Token Factory commands to match the existing ITS script command structure, replacing the old
--action
flag approach with individual commands using positional arguments. The changes include:interchainTokenFactory.js
to use individual commands (e.g.,deploy-interchain-token
) instead of the previous--action deployInterchainToken
formatits.js
patternsThe refactoring improves consistency across the codebase by standardizing the command-line interface pattern used throughout the project.
Confidence Score: 4/5
Important Files Changed
File Analysis
Sequence Diagram
Note
Refactors
evm/interchainTokenFactory.js
from a single--action
flag to kebab-case subcommands and updates workflows and docs to the new CLI.--action
-based interface with kebab-case subcommands (e.g.,deploy-interchain-token
,register-custom-token
,link-token
, etc.).main
signature to route by subcommand; passaction
explicitly tohandleTx
.canonical-interchain-token-id
,canonical-interchain-token-deploy-salt
).encodeITSDestination
instead ofencodeITSDestinationToken
; validate and gas estimation flow updated per subcommand.addOptionsToCommands(program, addEvmOptions, { address: true, salt: true })
.evm/README.md
with command references and examples.releases/evm/EVM-ITS-Release-Template.md
) to new subcommand syntax..github/workflows/test-evm.yaml
steps to use new subcommand-based factory commands (deploy, register, link).Written by Cursor Bugbot for commit f69020d. This will update automatically on new commits. Configure here.