-
Notifications
You must be signed in to change notification settings - Fork 29
chore(hedera): hedera ITS v2.1.1 upgrade #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Summary
This PR upgrades Hedera's Interchain Token Service (ITS) to v2.1.1 on both mainnet and testnet environments.
Key Changes:
- Updated
saltfrom "ITS v2.1.0" to "ITS v2.1.1" for both mainnet and testnet - Updated contract addresses for:
tokenManagerDeployerinterchainTokenDeployertokenManagertokenHandlerimplementationInterchainTokenFactoryimplementation
- Maintained consistent
proxySaltat "ITS v1.0.0" (as per custom instructions) addressandpredeployCodehashfields remain unchanged, as expected for a proxy upgrade
Issues Found:
- The
versionfield in both files remains at "2.1.0" but should be updated to "2.1.1" to match the salt and deployment version. This was correctly done in the stagenet upgrade (commit 59c3e26).
Confidence Score: 3/5
- This PR is generally safe but requires a version field correction before merging
- The changes follow the established upgrade pattern and correctly update contract addresses. However, the
versionfield was not updated from "2.1.0" to "2.1.1" in both config files, creating an inconsistency with the salt field and the actual deployment version. This is a metadata issue that should be corrected for accuracy, though it won't affect the deployed contracts themselves. - Both
axelar-chains-config/info/mainnet.jsonandaxelar-chains-config/info/testnet.jsonneed the version field updated to "2.1.1"
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| axelar-chains-config/info/mainnet.json | 3/5 | Updated Hedera ITS to v2.1.1 with new contract addresses, but version field not updated to match |
| axelar-chains-config/info/testnet.json | 3/5 | Updated Hedera ITS to v2.1.1 with new contract addresses, but version field not updated to match |
Sequence Diagram
sequenceDiagram
participant Deployer
participant ITS Proxy
participant Old Implementation
participant New Implementation v2.1.1
participant TokenManager
participant TokenHandler
participant TokenFactory
Note over Deployer,TokenFactory: Hedera ITS v2.1.1 Upgrade Process
Deployer->>New Implementation v2.1.1: Deploy new implementation contract
Note over New Implementation v2.1.1: Address: 0x1B13a9BaF8d3116C56CCDF3aa9049ad532a9C03d
Deployer->>TokenManager: Deploy new TokenManager implementation
Note over TokenManager: Address: 0xE89A3e8E7262d96BD5dB9568060B8DDB2e7B7bCD (mainnet)<br/>0xF0C255159c56DADC2559295e2427240484172Aba (testnet)
Deployer->>TokenHandler: Deploy new TokenHandler
Note over TokenHandler: Address: 0x563ee90271512e7a83D0cF31c46395F27a3f489f
Deployer->>TokenFactory: Deploy new InterchainTokenFactory implementation
Note over TokenFactory: Address: 0x4B4c1F7754026E00608f1f27e20ff5cDbB047A70 (mainnet)<br/>0x18e160AA6740bfa78091a6Aee08270d48CAf9944 (testnet)
Deployer->>ITS Proxy: Upgrade proxy to point to new implementation
ITS Proxy-->>Old Implementation: Stop routing calls
ITS Proxy-->>New Implementation v2.1.1: Start routing calls
Note over ITS Proxy: Proxy address remains unchanged:<br/>0xB5FB4BE02232B1bBA4dC8f81dc24C26980dE9e3C
Note over ITS Proxy: proxySalt stays at "ITS v1.0.0"<br/>salt updated to "ITS v2.1.1"
2 files reviewed, 2 comments
| "proxySalt": "ITS v1.0.0", | ||
| "deployer": "0x6f24A47Fc8AE5441Eb47EFfC3665e70e69Ac3F05", | ||
| "address": "0xB5FB4BE02232B1bBA4dC8f81dc24C26980dE9e3C", | ||
| "version": "2.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: version field should be updated to "2.1.1" to match the salt upgrade
| "version": "2.1.0", | |
| "version": "2.1.1", |
| "proxySalt": "ITS v1.0.0", | ||
| "deployer": "0x6f24A47Fc8AE5441Eb47EFfC3665e70e69Ac3F05", | ||
| "address": "0xB5FB4BE02232B1bBA4dC8f81dc24C26980dE9e3C", | ||
| "version": "2.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: version field should be updated to "2.1.1" to match the salt upgrade
| "version": "2.1.0", | |
| "version": "2.1.1", |
Note
Upgrades Hedera InterchainTokenService to v2.1.1 on mainnet and testnet, rotating component addresses and updating InterchainTokenFactory implementations.
salttoITS v2.1.1and rotatetokenManagerDeployer,interchainTokenDeployer,tokenManager,tokenHandler, andimplementationaddresses.implementationaddress forinterchain-token-factoryon both networks.Written by Cursor Bugbot for commit 317b7f2. This will update automatically on new commits. Configure here.