feat: combine ITS add-trusted-chains commands #827
+60
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add common script for all chain types - update instructions in EVM ITS release template
milapsheth
reviewed
Jun 23, 2025
|
|
||
| const commands = [ | ||
| { | ||
| cmd: `ts-node evm/its.js set-trusted-chains ${chain} hub -n all`, |
There was a problem hiding this comment.
ideally, we should just import the functions directly and call it instead of via a shell. But in this case, it might be more effort to do that, so maybe this is fine
| } | ||
|
|
||
| async function setTrustedChainsAll(config, args, options) { | ||
| const chain = process.env.CHAIN; |
There was a problem hiding this comment.
avoid parsing env vars/cli args directly. Use the commander library to get CLI inputs like we do in all our scripts
There was a problem hiding this comment.
Also ignoreChainNames can be set to true, if u need a chain name in script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-9612