Skip to content

fix(sign): handle undeployed contract by checking code === '0x' or null #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(sign): handle undeployed contract by checking code === '0x' or null #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/account-sdk/src/sign/base-account/utils/findOwnerIndex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export async function findOwnerIndex({
// Check index of owner in the factoryData
// Note: importing an undeployed contract might need to be handled differently
// The implemention will likely require the signer to tell us the index
if (!code && factory && factoryData) {
if ((code === '0x' || code == null) && factory && factoryData) {
const initData = decodeFunctionData({
abi: factoryAbi,
data: factoryData,
Expand Down