-
Notifications
You must be signed in to change notification settings - Fork 319
template for gas & elasticity increase #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leopoldjoy
merged 12 commits into
base:main
from
leopoldjoy:feat/add-template-for-gas-and-elasticity-increase
Nov 17, 2025
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c266254
add WIP template for gas and elasticity increase
leopoldjoy dc2bc7c
add validations directory creation commands to Makefile
leopoldjoy b8d6d8a
update override function comments in IncreaseEip1559ElasticityAndIncr…
leopoldjoy 827bf87
update Makefile commands for rollback usage in Signer Tool
leopoldjoy c4c32a4
update to latest Signer Tool commit hash in Makefile
leopoldjoy a85c6e3
update usage instructions for gas limit + elasticity increase templat…
leopoldjoy cfd4803
Merge branch 'main' into feat/add-template-for-gas-and-elasticity-inc…
leopoldjoy f1b9bfc
add further usage instructions in README.md
leopoldjoy 5598598
add missing TODO instructions in .env
leopoldjoy b47e360
add process kill instructions to task's README.md
leopoldjoy 29f6e7d
fix formatting, improve override logic and read DENOMINATOR from Syst…
leopoldjoy 8b04939
make fixes / improvements from review
leopoldjoy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| OP_COMMIT=TODO # Recommend using the version of https://github.com/ethereum-optimism/optimism that the current SystemConfig contract is on | ||
| BASE_CONTRACTS_COMMIT=TODO # Recommend using the latest version of https://github.com/base-org/contracts | ||
|
|
||
| # TODO: ensure `SYSTEM_CONFIG` is correct on the given network | ||
| SYSTEM_CONFIG=0x73a79Fab69143498Ed3712e519A88a918e1f4072 | ||
| # TODO: ensure `OWNER_SAFE` is correct on the given network | ||
| OWNER_SAFE=0x14536667Cd30e52C0b458BaACcB9faDA7046E056 | ||
|
|
||
| # TODO: ensure the current and future gas limits are set properly | ||
| OLD_GAS_LIMIT=TODO | ||
| NEW_GAS_LIMIT=TODO | ||
|
|
||
| # TODO: ensure the current and future elasticities are set properly | ||
| OLD_ELASTICITY=TODO | ||
| NEW_ELASTICITY=TODO | ||
|
|
||
| # TODO: ensure `SENDER` is a signer for `OWNER_SAFE` on the given network | ||
| SENDER=0x1841CB3C2ce6870D0417844C817849da64E6e937 | ||
|
|
||
| RECORD_STATE_DIFF=true | ||
26 changes: 26 additions & 0 deletions
26
setup-templates/template-gas-and-elasticity-increase/FACILITATOR.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Facilitator Guide | ||
|
|
||
| Guide for facilitators after collecting signatures from signers. | ||
|
|
||
| ### 1. Update repo: | ||
|
|
||
| ```bash | ||
| cd contract-deployments | ||
| git pull | ||
| cd mainnet/TODO | ||
| make deps | ||
| ``` | ||
|
|
||
| ### 2. Execute upgrade | ||
|
|
||
| ```bash | ||
| SIGNATURES=AAABBBCCC make execute | ||
| ``` | ||
|
|
||
| ### 3. (**ONLY** if needed) Execute upgrade rollback | ||
|
|
||
| > [!IMPORTANT] THIS SHOULD ONLY BE PERFORMED IN THE EVENT THAT WE NEED TO ROLLBACK | ||
leopoldjoy marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ```bash | ||
| SIGNATURES=AAABBBCCC make execute-rollback | ||
| ``` | ||
61 changes: 61 additions & 0 deletions
61
setup-templates/template-gas-and-elasticity-increase/Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| include ../../Makefile | ||
| include ../../Multisig.mk | ||
| include ../.env | ||
| include .env | ||
|
|
||
| ifndef LEDGER_ACCOUNT | ||
| override LEDGER_ACCOUNT = 0 | ||
| endif | ||
|
|
||
| ifndef ROLLBACK_NONCE_OFFSET | ||
| override ROLLBACK_NONCE_OFFSET = 1 | ||
| endif | ||
|
|
||
| RPC_URL = $(L1_RPC_URL) | ||
| SCRIPT_NAME = IncreaseEip1559ElasticityAndIncreaseGasLimitScript | ||
|
|
||
| .PHONY: gen-validation | ||
| gen-validation: checkout-signer-tool run-script | ||
|
|
||
| .PHONY: run-script | ||
| run-script: | ||
| mkdir validations; \ | ||
| cd $(SIGNER_TOOL_PATH); \ | ||
| npm ci; \ | ||
| bun run scripts/genValidationFile.ts --rpc-url $(L1_RPC_URL) \ | ||
| --workdir .. --forge-cmd 'forge script --rpc-url $(L1_RPC_URL) \ | ||
leopoldjoy marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| $(SCRIPT_NAME) --sig "sign(address[])" [] --sender $(SENDER)' --out ../validations/base-signer-upgrade.json; | ||
leopoldjoy marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| .PHONY: execute | ||
| execute: | ||
| FROM_GAS_LIMIT=$(FROM_GAS_LIMIT) \ | ||
| TO_GAS_LIMIT=$(TO_GAS_LIMIT) \ | ||
| FROM_ELASTICITY=$(FROM_ELASTICITY) \ | ||
| TO_ELASTICITY=$(TO_ELASTICITY) \ | ||
| $(call MULTISIG_EXECUTE,$(SIGNATURES)) | ||
leopoldjoy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # Manually swap the old and new values for the gas limit and elasticity when passing them in for the rollback | ||
leopoldjoy marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| .PHONY: gen-validation-rollback | ||
| gen-validation-rollback: checkout-signer-tool run-script-rollback | ||
|
|
||
| .PHONY: run-script-rollback | ||
| run-script-rollback: | ||
| cd $(SIGNER_TOOL_PATH); \ | ||
| npm ci; \ | ||
| bun run scripts/genValidationFile.ts --rpc-url $(RPC_URL) \ | ||
| --workdir .. --forge-cmd 'FROM_GAS_LIMIT=$(TO_GAS_LIMIT) \ | ||
| TO_GAS_LIMIT=$(FROM_GAS_LIMIT) FROM_ELASTICITY=$(TO_ELASTICITY) TO_ELASTICITY=$(FROM_ELASTICITY) \ | ||
| SAFE_NONCE=$(shell expr $$(cast call $(OWNER_SAFE) "nonce()" --rpc-url $(RPC_URL) | cast to-dec) + $(ROLLBACK_NONCE_OFFSET)) \ | ||
| forge script --rpc-url $(RPC_URL) \ | ||
| $(SCRIPT_NAME) --sig "sign(address[])" [] --sender $(SENDER)' --out ../validations/base-signer-rollback.json; | ||
|
|
||
| .PHONY: execute-rollback | ||
| execute-rollback: | ||
| FROM_GAS_LIMIT=$(TO_GAS_LIMIT) \ | ||
| TO_GAS_LIMIT=$(FROM_GAS_LIMIT) \ | ||
| FROM_ELASTICITY=$(TO_ELASTICITY) \ | ||
| TO_ELASTICITY=$(FROM_ELASTICITY) \ | ||
| SAFE_NONCE=$(shell expr $$(cast call $(OWNER_SAFE) "nonce()" --rpc-url $(RPC_URL) | cast to-dec) + $(ROLLBACK_NONCE_OFFSET)) \ | ||
| forge script --rpc-url $(RPC_URL) $(SCRIPT_NAME) \ | ||
| --sig "run(bytes)" $(SIGNATURES) --ledger --hd-paths "m/44'/60'/$(LEDGER_ACCOUNT)'/0/0" --broadcast | ||
88 changes: 88 additions & 0 deletions
88
setup-templates/template-gas-and-elasticity-increase/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| # Update Gas Limit & Elasticity in L1 `SystemConfig` | ||
|
|
||
| Status: TODO[READY TO SIGN|DONE] | ||
|
|
||
| ## Description | ||
|
|
||
| We are updating the gas limit and elasticity to improve TPS and reduce gas fees. | ||
|
|
||
| This runbook invokes the following script which allows our signers to sign the same call with two different sets of parameters for our Incident Multisig, defined in the [base-org/contracts](https://github.com/base/contracts) repository: | ||
|
|
||
| `IncreaseEip1559ElasticityAndIncreaseGasLimitScript` -- This script will update the gas limit to our new limit of TODO gas and TODO elasticity if invoked as part of the "upgrade" process, or revert to the old limit of TODO gas and TODO elasticity if invoked as part of the "rollback" process. | ||
|
|
||
| The values we are sending are statically defined in the `.env` file. | ||
|
|
||
| > [!IMPORTANT] We have two transactions to sign. Please follow | ||
| > the flow for both "Approving the Update transaction" and | ||
| > "Approving the Rollback transaction". Hopefully we only need | ||
| > the former, but will have the latter available if needed. | ||
|
|
||
| ## Install dependencies | ||
|
|
||
| ### 1. Update foundry | ||
|
|
||
| ```bash | ||
| foundryup | ||
| ``` | ||
|
|
||
| ### 2. Install Node.js if needed | ||
|
|
||
| First, check if you have node installed | ||
|
|
||
| ```bash | ||
| node --version | ||
| ``` | ||
|
|
||
| If you see a version output from the above command, you can move on. Otherwise, install node | ||
|
|
||
| ```bash | ||
| brew install node | ||
| ``` | ||
|
|
||
| ## Approving the Update transaction | ||
|
|
||
| ### 1. Update repo: | ||
|
|
||
| ```bash | ||
| cd contract-deployments | ||
| git pull | ||
| ``` | ||
|
|
||
| ### 2. Run the signing tool (NOTE: do not enter the task directory. Run this command from the project's root). | ||
|
|
||
| ```bash | ||
| make sign-task | ||
| ``` | ||
|
|
||
| ### 3. Open the UI at [http://localhost:3000](http://localhost:3000) | ||
|
|
||
| Be sure to select the correct task from the list of available tasks to sign (**not** the rollback task). | ||
|
|
||
| ### 4. Send signature to facilitator | ||
|
|
||
| You may now kill the Signer Tool process in your terminal window by running `Ctrl + C`. | ||
|
|
||
| ## Approving the Rollback transaction | ||
leopoldjoy marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| Complete the above steps for `Approving the Update transaction` before continuing below. | ||
|
|
||
| ### 1. Update repo: | ||
|
|
||
| ```bash | ||
| cd contract-deployments | ||
| git pull | ||
| ``` | ||
|
|
||
| ### 2. Run the signing tool (NOTE: do not enter the task directory. Run this command from the project's root). | ||
|
|
||
| ```bash | ||
| make sign-task | ||
| ``` | ||
|
|
||
| ### 3. Open the UI at [http://localhost:3000](http://localhost:3000) | ||
|
|
||
| Be sure to select the correct task from the list of available tasks to sign (ensure it **is** the rollback task). | ||
|
|
||
| ### 4. Send signature to facilitator | ||
|
|
||
| You may now kill the Signer Tool process in your terminal window by running `Ctrl + C`. | ||
20 changes: 20 additions & 0 deletions
20
setup-templates/template-gas-and-elasticity-increase/foundry.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| [profile.default] | ||
| src = 'src' | ||
| out = 'out' | ||
| libs = ['lib'] | ||
| broadcast = 'records' | ||
| fs_permissions = [ {access = "read-write", path = "./"} ] | ||
| optimizer = true | ||
| optimizer_runs = 999999 | ||
| solc_version = "0.8.15" | ||
| via-ir = false | ||
| remappings = [ | ||
| '@eth-optimism-bedrock/=lib/optimism/packages/contracts-bedrock/', | ||
| '@openzeppelin/contracts/=lib/openzeppelin-contracts/contracts', | ||
| '@openzeppelin/contracts-upgradeable/=lib/openzeppelin-contracts-upgradeable/contracts', | ||
| '@rari-capital/solmate/=lib/solmate/', | ||
| '@base-contracts/=lib/base-contracts', | ||
| '@solady/=lib/solady/src/' | ||
| ] | ||
|
|
||
| # See more config options https://github.com/foundry-rs/foundry/tree/master/config |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.