Add alias for amd64 to x86_64
#114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`amd64` gets returned by `repository_ctx.os.arch`, and yet the CPU constraint only has `x86_64`. This becomes un-ergonomic when trying to set up repository and toolchain rules—I constantly have to ask myself which is which/try it out. `arm64` has an alias to `aarch64`, so there is precedent for including an equivalent name when the implementation-canonical name may not be as friendly or widely known.
|
This is similar to #43, implemented the way consensus on that PR actually suggests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amd64gets returned byrepository_ctx.os.arch, and yet the CPU constraint only hasx86_64. This becomes un-ergonomic when trying to set up repository and toolchain rules—I constantly have to ask myself which is which/try it out.arm64has an alias toaarch64, so there is precedent for including an equivalent name when the implementation-canonical name may not be as friendly or widely known.