Upgrade mediator to aca-py 1.1.0 #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
WadeBarnes
commented
Nov 20, 2024
WadeBarnes
commented
- Migrate image and repository references to OpenWallet Foundation repositories.
- Migrate image and repository references to OpenWallet Foundation repositories. Signed-off-by: Wade Barnes <[email protected]>
|
These changes have been deployed to @jleach, What's the best way to test the |
esune
requested changes
Nov 20, 2024
Comment on lines
7
to
9
| RUN pip install --no-cache-dir git+https://github.com/openwallet-foundation/acapy-plugins.git@main#subdirectory=redis_events | ||
| # Firebase Push Notifications | ||
| RUN pip install --no-cache-dir -e "git+https://github.com/hyperledger/aries-mediator-service.git@main#egg=firebase_push_notifications&subdirectory=acapy/plugins/firebase_push_notifications" | ||
| # ======================================================================================================================================== | ||
| RUN pip install --no-cache-dir git+https://github.com/openwallet-foundation/acapy-plugins.git@main#subdirectory=firebase_push_notifications |
There was a problem hiding this comment.
We should probably install the tagged version of the plugin rather than the one from main. You can see an example of how we do it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.