Added support for s390x wheel package #667
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benfred are you able to access the secrets used in workflow? |
|
@benfred can you please review the changes |
|
@simonrw @benfred @jarus @auscompgeek can you please review the changes? |
auscompgeek
suggested changes
May 31, 2024
| with: | ||
| host: ${{secrets.S390X_SSH_HOST}} | ||
| username: ${{secrets.S390X_SSH_USER }} | ||
| key: ${{secrets.S390X_SSH_KEY}} |
There was a problem hiding this comment.
The use of secrets will break building any PR, including this one.
There was a problem hiding this comment.
If those secret variables are included , then it won't break at all. I already allowed edits and access to secrets to maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified mod.rs for s390x
Created workflow for generating wheel package for s390x: