Skip to content

Conversation

@bennypowers
Copy link
Owner

No description provided.

@bennypowers bennypowers requested a review from Copilot July 8, 2025 18:43

This comment was marked as outdated.

@bennypowers bennypowers marked this pull request as draft July 8, 2025 18:47
@bennypowers bennypowers requested a review from Copilot July 8, 2025 20:03

This comment was marked as outdated.

@bennypowers bennypowers marked this pull request as ready for review July 8, 2025 20:08
@bennypowers bennypowers requested a review from Copilot July 8, 2025 20:08
@bennypowers bennypowers merged commit 2927954 into main Jul 8, 2025
4 checks passed
@bennypowers bennypowers deleted the feat/go/initial branch July 8, 2025 20:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds Go support to the splitjoin plugin by registering Go in Treesitter setup, providing queries, defaults, and split/join implementations, and adding tests and documentation updates.

  • Integrates Go into ensure_installed and test setup
  • Implements Go-specific split/join logic and defaults
  • Adds queries, tests, and README entries for Go support

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/init.lua Added go and html to Treesitter ensure_installed
test/helpers.lua Switched to vim.treesitter.get_parser API
test/go_spec.lua New test suite for Go split/join
queries/go/splitjoin.scm Added Go capture nodes for split/join
queries/css/splitjoin.scm Added an extra arguments capture (CSS)
lua/splitjoin/util/options.lua Registered Go defaults in options
lua/splitjoin/languages/go/functions.lua Added Go struct split/join functions
lua/splitjoin/languages/go/defaults.lua Defined Go defaults for split/join
lua/splitjoin.lua Added nil-check guard before parsing
README.md Documented HTML and Go support
Comments suppressed due to low confidence (2)

queries/css/splitjoin.scm:9

  • The extra parentheses make this query invalid. It should be (arguments @splitjoin.css.arguments).
((arguments) @splitjoin.css.arguments)

lua/splitjoin.lua:29

  • [nitpick] The indentation here is inconsistent; align the if tsparser == nil then return end with the local tsparser = get_parser(bufnr) line for readability.
     if tsparser == nil then return end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants