Skip to content

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 15, 2025

  • updates tooltip font size

Before:

image

After:

image

Summary by CodeRabbit

  • Style
    • Updated active button styling to use a smaller text size, improving visual hierarchy and making active states more distinct.
    • Enhances readability and reduces visual clutter in dense interfaces by preventing oversized labels on active buttons.
    • Improves consistency across button states, aligning active buttons with the overall typographic scale for a cleaner, more polished look.

@haslinghuis haslinghuis added this to the 2025.12 milestone Sep 15, 2025
@haslinghuis haslinghuis self-assigned this Sep 15, 2025
@haslinghuis haslinghuis moved this to App in 2025.12.0 Sep 15, 2025
Copy link
Contributor

coderabbitai bot commented Sep 15, 2025

Walkthrough

A single CSS modification was made: a font-size declaration (0.75rem) was added to the existing button.active rule in src/css/main.less. No other files or properties were changed.

Changes

Cohort / File(s) Summary of Changes
Styles: Active button font size
src/css/main.less
Added font-size: 0.75rem to button.active rule.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning No pull request description was provided while this repository requires using the provided template; required details such as motivation, what changed, testing steps, and related issue numbers are missing, so the description check fails. Please complete the PR description using the repository template: state the motivation and rationale, list the files/areas changed, provide steps to reproduce or test the visual change, and add any related issue references (e.g., "Fixes #").
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Reduce Tippy font size" concisely describes a font-size reduction, which matches the change adding font-size: 0.75rem in src/css/main.less; however the change modifies button.active rather than an explicit Tippy selector, so the title is slightly imprecise though still related to the change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copy link
Contributor

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/css/main.less (1)

1635-1640: This likely doesn’t reduce the tooltip font size. Verify computed value.

Body sets font-size: 12px (Line 20). 0.75rem resolves to 12px on a 16px root, so tooltips may remain unchanged. If the goal is smaller than current, consider 0.6875rem (~11px) and set a tighter line-height for readability.

Suggested tweak:

 .tippy-box[data-theme~="custom"] {
   background: var(--surface-300);
   border: 2px solid var(--primary-500);
   border-radius: 0.5rem;
   color: var(--text);
-  font-size: 0.75rem;
+  /* ~11px on 16px root; adjust as needed */
+  font-size: 0.6875rem;
+  line-height: 1.25;
 }

Please confirm the computed font-size before/after via DevTools on a few screens (default zoom and 125%/150% OS scaling).

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 04d4255 and 60607cf.

📒 Files selected for processing (1)
  • src/css/main.less (1 hunks)

Copy link
Member

@VitroidFPV VitroidFPV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was gonna have a try at this when I would've gotten back from Uni, good spot

@haslinghuis haslinghuis merged commit 02ce6eb into betaflight:master Sep 15, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from App to Done in 2025.12.0 Sep 15, 2025
@haslinghuis haslinghuis deleted the reduce-tippy-font-size branch September 15, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants