-
-
Notifications
You must be signed in to change notification settings - Fork 994
Reduce Tippy font size #4610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Tippy font size #4610
Conversation
WalkthroughA single CSS modification was made: a font-size declaration (0.75rem) was added to the existing button.active rule in src/css/main.less. No other files or properties were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview URL: https://60607cfe.betaflight-configurator.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/css/main.less (1)
1635-1640
: This likely doesn’t reduce the tooltip font size. Verify computed value.Body sets font-size: 12px (Line 20). 0.75rem resolves to 12px on a 16px root, so tooltips may remain unchanged. If the goal is smaller than current, consider 0.6875rem (~11px) and set a tighter line-height for readability.
Suggested tweak:
.tippy-box[data-theme~="custom"] { background: var(--surface-300); border: 2px solid var(--primary-500); border-radius: 0.5rem; color: var(--text); - font-size: 0.75rem; + /* ~11px on 16px root; adjust as needed */ + font-size: 0.6875rem; + line-height: 1.25; }Please confirm the computed font-size before/after via DevTools on a few screens (default zoom and 125%/150% OS scaling).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was gonna have a try at this when I would've gotten back from Uni, good spot
Before:
After:
Summary by CodeRabbit