Skip to content

Conversation

@ligenxxxx
Copy link
Contributor

@ligenxxxx ligenxxxx commented Nov 6, 2025

Beeper pin need to be inverted. Otherwise, the beeper will not work.
#953

Summary by CodeRabbit

  • New Features
    • Added an inverted beeper behavior configuration option for HDZERO_AIO15 devices.
    • Users can now select beeper signal polarity to match their hardware wiring.
    • Improves flexibility and compatibility with a wider range of beeper hardware and setups.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 6, 2025

Walkthrough

A new BEEPER_INVERTED macro is added to the HDZERO_AIO15 configuration header to enable inverted beeper behavior. This is a single-line configuration addition with no functional or control-flow changes.

Changes

Cohort / File(s) Summary
HDZERO_AIO15 Configuration
configs/HDZERO_AIO15/config.h
Added #define BEEPER_INVERTED macro to enable inverted beeper behavior

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is extremely minimal and lacks the required structure, mandatory sections, and compliance checklist from the template. Add all required sections from the template including: mandatory review requirements, hardware compliance declarations, housekeeping items, and the completed checklist with hardware testing and validation confirmations.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and specifically describes the main change: adding an inverted beeper pin configuration for the HDZERO AIO15 hardware.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sugaarK
Copy link
Member

sugaarK commented Nov 6, 2025

checked on hardware this does fix the issue

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR needs a rebase, created a new one

@sugaarK sugaarK closed this Nov 6, 2025
@sugaarK
Copy link
Member

sugaarK commented Nov 6, 2025

new pr that has been made on an update fork supersedes this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants