-
Notifications
You must be signed in to change notification settings - Fork 187
[ENH] Clarify that "source datasets" do not have to be BIDS, and provide definitions for DOI and URL #2203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2203 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 20 20
Lines 1608 1608
=======================================
Hits 1330 1330
Misses 278 278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
display_name: Source Datasets | ||
description: | | ||
Used to specify the locations and relevant attributes of all source datasets. | ||
Used to specify the locations and relevant attributes of all source datasets (BIDS or not). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine. Duplicating in the DOI and URL fields seems excessive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is just a result of excessive (if not wrong to start with) specification in both of those. I do not see a need to make them "source dataset specific" and clearly should not relate to "all".
Co-authored-by: Chris Markiewicz <[email protected]>
came up while reviewing... but could be wrong and we demand only BIDS datasets there?