Skip to content

Conversation

yarikoptic
Copy link
Collaborator

came up while reviewing... but could be wrong and we demand only BIDS datasets there?

@yarikoptic yarikoptic added the enhancement New feature or request label Sep 5, 2025
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.71%. Comparing base (df8a853) to head (8f9c9a5).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2203   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files          20       20           
  Lines        1608     1608           
=======================================
  Hits         1330     1330           
  Misses        278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

display_name: Source Datasets
description: |
Used to specify the locations and relevant attributes of all source datasets.
Used to specify the locations and relevant attributes of all source datasets (BIDS or not).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. Duplicating in the DOI and URL fields seems excessive.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is just a result of excessive (if not wrong to start with) specification in both of those. I do not see a need to make them "source dataset specific" and clearly should not relate to "all".

@effigies effigies changed the title Clarify that "source datasets" do not have to be BIDS [ENH] Clarify that "source datasets" do not have to be BIDS Sep 5, 2025
@yarikoptic yarikoptic changed the title [ENH] Clarify that "source datasets" do not have to be BIDS [ENH] Clarify that "source datasets" do not have to be BIDS, and provide definitions for DOI and URL Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants