Skip to content

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 24, 2025

Related to bids-standard/bids-specification#1926.

Changes proposed:

  • Add + signs to the regular expressions for label entities in the bids and derivatives config files.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe. This will expand the scope of entities parseable with validate=False, but will not make them valid until the schema adds this.

@effigies effigies merged commit 85eacf2 into bids-standard:master Feb 24, 2025
23 checks passed
@tsalo tsalo deleted the plus-signs branch February 25, 2025 17:17
effigies added a commit that referenced this pull request Mar 13, 2025
Version 0.19.0 (March 05, 2025)

New feature release in the 0.19.x series.

This release adds plus signs to labels and suffixes, anticipating the
release of BIDS 1.10.1 or 1.11.0 (whichever is next).
Until the BIDS specification is updated and the ``bidsschematools``
package containing the updated schema is published, files with ``+`` will
not validate, but can still be indexed with ``BIDSLayout(..., validate=False)``.

Several small fixes resolving issues with BIDS Stats Models are included,
and complex JSON metadata (lists and objects) will now play more nicely with
contexts where they need to be hashed.

* FIX: Catch StopIteration on directory walk (#1124)
* FIX: Ensure dotfiles are always filtered (#1123)
* FIX: Copy entities dict before modifying run variable type (#1120)
* FIX: Allow numpy arrays to treat PaddedInt like int (#1119)
* FIX: Make lists and dicts hashable (#1112)
* ENH: Allow plus signs in labels (#1117)
* MNT: Remove formulaic upper bound (#1121)
* MNT: Use tox-uv to ease lower bound checking, test on Python 3.13 (#1109)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants