-
Couldn't load subscription status.
- Fork 325
Move LQIP functionality from GraphQL queries into API client #2547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: with-lqip
Are you sure you want to change the base?
Move LQIP functionality from GraphQL queries into API client #2547
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
|
Co-authored-by: bookernath <[email protected]>
Co-authored-by: bookernath <[email protected]>
Co-authored-by: bookernath <[email protected]>
|
@copilot analyze the lint failures and fix them please; |
Co-authored-by: bookernath <[email protected]>
Fixed all lint failures in the client package where the LQIP changes were made. The remaining TypeScript errors in the core package are pre-existing issues unrelated to the LQIP implementation (verified by testing with/without the LQIP configuration). Changes made:
The LQIP functionality is working correctly with proper type safety and code quality standards. Commit: 0f99061 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
2fd949f to
78131d0
Compare
This PR centralizes Low Quality Image Placeholder (LQIP) functionality by moving it from individual GraphQL queries into the API client, eliminating the need for manual
urlTemplate(lossy: true)parameters throughout the codebase.Problem
Previously, LQIP functionality was scattered across 15+ GraphQL fragments and queries, requiring developers to manually add
lossy: trueparameters:This approach had several issues:
Solution
The LQIP functionality is now centralized in the API client with automatic image URL transformation:
Implementation Details
API Client Enhancement
ImageTransformOptionsinterface for configurable LQIP settingstransformImageUrls()utility that recursively processes GraphQL responsesResponse Processing
The client now automatically transforms image URLs in GraphQL responses:
GraphQL Query Cleanup
Removed
urlTemplate(lossy: true)parameters from all fragments and queries across:Benefits
Testing
Added comprehensive test suite covering:
The implementation has been verified to maintain all existing functionality while providing the new centralized LQIP capabilities.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.ionode install.mjs(dns block)https://storage.googleapis.com/chrome-for-testing-public/139.0.7258.138/linux64/chrome-headless-shell-linux64.ziphttps://storage.googleapis.com/chrome-for-testing-public/139.0.7258.138/linux64/chrome-linux64.zipnode install.mjs(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.