Skip to content

Conversation

bc-dronov
Copy link
Contributor

@bc-dronov bc-dronov commented Sep 8, 2025

What/Why?

StripeShippingAddress migrated to the functional

Rollout/Rollback

Revert this PR

Testing

Manual testing

Screen.Recording.2025-09-10.at.12.50.19.mov

@bc-dronov bc-dronov requested a review from a team as a code owner September 8, 2025 10:33
}
};

runInitialize();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runInitialize();
void runInitialize();

);
};

export default StripeShippingAddressDisplay;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bc-peng I think we have to configure a linter to make this changes automatically

@bc-dronov bc-dronov requested a review from PavlenkoM September 9, 2025 10:29
@bc-dronov bc-dronov force-pushed the feat/stripe_shipping_address_display_functional branch from 09343e6 to 321017a Compare September 10, 2025 09:38
@bc-dronov bc-dronov merged commit ac8f853 into master Sep 15, 2025
11 checks passed
@bc-dronov bc-dronov deleted the feat/stripe_shipping_address_display_functional branch September 15, 2025 11:38
@bc-launchbay
Copy link

checkout-js deployed to Integration US
success 20250915115522 by Launchbay

@bc-launchbay
Copy link

checkout-js deployed to Staging US
success 20250915115522 by Launchbay

Copy link

⚡️ Lighthouse results

🖥️ Desktop:

Category Score
🟢 Performance 93
🟢 Accessibility 91
🟠 Best practices 78

📱 Mobile:

Category Score
🟠 Performance 60
🟢 Accessibility 94
🟠 Best practices 78

@bc-launchbay
Copy link

checkout-js deployed to Production US
success 20250915115522 by Launchbay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants