24 rollover bugfixes using ELAPSE and PENDING macros #2993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 rollover bugfixes using ELAPSED and PENDING macros
digant73
reviewed
Sep 17, 2025
TFT/src/User/my_misc.h
Outdated
| #define MIN_TO_SEC(t) (t * 60) // minute to seconds | ||
| #define MIN_TO_MS(t) (SEC_TO_MS(t) * 60) // minute to milliseconds | ||
|
|
||
| // timer rollover safe functions |
There was a problem hiding this comment.
I would move this macros just above // time conversion
There was a problem hiding this comment.
I would move this macros just above
// time conversion
Done!
There was a problem hiding this comment.
Code is final and ready for release.
Moved "timer rollover safe functions" to above "time conversion" as suggested by digant73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves 24 timer rollover bug using ELAPSED and PENDING macros.
Requirements
None
Description
This PR solves 24 timer rollover bugs I found in the code. These bugs can make the TFT behave erratically, but only after a long time. The cause is the 32 bit timer register rollover from 0xFFFFFFFF to 0. When using incorrect timer math the results can be incorrect.
To solve the bugs I use a strategy bored by Marlin, which uses macros to prevent issues.
PENDING(when) with "when" a time in the future.
ELAPSED(starttime, interval) with starttime a time in the past, and the interval the time to check for if it has elapsed since the starttime.
Benefits
Related Issues
#2992