Fix notification title text visible behind toast message #2998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix notification title text visible behind toast message. Title position was hard coded (x=10), use START_X variable instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix notification title text partly visible behind toast message. Title position was hard coded (x=10), use START_X variable instead.
Description
The notification menu title text is still partly visible behind a toast message. This is because the title text position is hard coded at x=10, while other graphics items use a framework based on calculated variables (START_X, START_Y etc.).
The toast icon starts at START_X, which is 12 for a 480x320 display. So 2 pixels of the title text will still be visible behind the toast message.
Benefits
Fixes graphical corruption/misalignment, improves consistency of graphical layout independent of the TFT resolution, no hardcoded positions, but calculated position like other graphical items on the screen.
Related Issues
None